Comments on: Porting upb to C++? http://blog.reverberate.org/2009/11/28/porting-upb-to-c/ parsing, performance, minimalism with C99 Thu, 26 Jan 2012 04:15:43 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Rehno Lindeque http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1493 Rehno Lindeque Sun, 06 Dec 2009 11:50:10 +0000 http://blog.reverberate.org/?p=287#comment-1493 I've also been lazily contemplating upb for use in my projects. Since I tend to write my code in strange languages like D and Haskell, I'll second the other's comments! I would not mind having a thin C++ wrapper though. I’ve also been lazily contemplating upb for use in my projects. Since I tend to write my code in strange languages like D and Haskell, I’ll second the other’s comments! I would not mind having a thin C++ wrapper though.

]]> By: Sam Quigley http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1487 Sam Quigley Wed, 02 Dec 2009 07:52:42 +0000 http://blog.reverberate.org/?p=287#comment-1487 Have you checked with the security team about this yet? C++ might reduce the number of potentially unsafe manual casting that goes on in the code, but it also introduces a whole host of (often very subtle) security risks of its own… (For example, see: http://chargen.matasano.com/chargen/2009/10/9/a-c-challenge.html and some of the links there) Depending on how much you're planning on changing — and depending on your security folks — it might well be faster to tighten up the current codebase than to rewrite it. (It's been a little while since I looked at the code, and I certainly haven't tried to do a formal review, but I didn't notice too many scary things going on in there…) On a more selfish note — I too was eyeing upb for use in a (pure C) project of mine, and would just as soon see it stay C… So take my comments with a grain of salt. :) -sq Have you checked with the security team about this yet? C++ might reduce the number of potentially unsafe manual casting that goes on in the code, but it also introduces a whole host of (often very subtle) security risks of its own… (For example, see: http://chargen.matasano.com/chargen/2009/10/9/a-c-challenge.html and some of the links there) Depending on how much you’re planning on changing — and depending on your security folks — it might well be faster to tighten up the current codebase than to rewrite it. (It’s been a little while since I looked at the code, and I certainly haven’t tried to do a formal review, but I didn’t notice too many scary things going on in there…)

On a more selfish note — I too was eyeing upb for use in a (pure C) project of mine, and would just as soon see it stay C… So take my comments with a grain of salt. :)

-sq

]]> By: Alejandro M. http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1485 Alejandro M. Tue, 01 Dec 2009 17:59:39 +0000 http://blog.reverberate.org/?p=287#comment-1485 assuming the generated C code is good, why not? ;-) thanks! assuming the generated C code is good, why not? ;-) thanks!

]]> By: Josh http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1484 Josh Tue, 01 Dec 2009 17:55:42 +0000 http://blog.reverberate.org/?p=287#comment-1484 @Alejandro: Wow, I didn't realize there was already someone wanting to use upb on an embedded platform! I definitely want to keep supporting your use case if I can. I think the best way forward will be for me to get a C++ to C translator like Comeau C++. Then I can keep writing in C++, but ship C files that you can build with a plain C compiler. Do you think that will work for you? @Alejandro: Wow, I didn’t realize there was already someone wanting to use upb on an embedded platform! I definitely want to keep supporting your use case if I can. I think the best way forward will be for me to get a C++ to C translator like Comeau C++. Then I can keep writing in C++, but ship C files that you can build with a plain C compiler. Do you think that will work for you?

]]> By: Alejandro M. http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1483 Alejandro M. Tue, 01 Dec 2009 17:02:33 +0000 http://blog.reverberate.org/?p=287#comment-1483 @Josh: Hi! You mentioned my reason... I work on a CXX-free embedded controller. Moving from ASN.1 to protocol buffer at IPC (hate threads) level thanks to your awesome upb and I was starting to write the Lua bindings to finish the migration integrating the http front-end and some Lua based helpers running inside the controller. So porting ucb to C++ because will hit me... badly :( ... your implementation is great!. I understand porting it to C++ will save you some lines... but maybe some refactoring can help to reduce the complexity without having to switch to C++? you can do all the bindings you aim keeping it in C... with all it's current benefits @Josh: Hi! You mentioned my reason… I work on a CXX-free embedded controller. Moving from ASN.1 to protocol buffer at IPC (hate threads) level thanks to your awesome upb and I was starting to write the Lua bindings to finish the migration integrating the http front-end and some Lua based helpers running inside the controller. So porting ucb to C++ because will hit me… badly :( … your implementation is great!. I understand porting it to C++ will save you some lines… but maybe some refactoring can help to reduce the complexity without having to switch to C++? you can do all the bindings you aim keeping it in C… with all it’s current benefits

]]> By: Josh http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1482 Josh Tue, 01 Dec 2009 16:30:55 +0000 http://blog.reverberate.org/?p=287#comment-1482 @Alejandro: If you want to influence my decision, you should tell me why you don't want me to. :) I definitely have resisted, but practical reasons are demanding that I do. But maybe you are thinking of practical reasons that I'm missing. @Alejandro: If you want to influence my decision, you should tell me why you don’t want me to. :) I definitely have resisted, but practical reasons are demanding that I do. But maybe you are thinking of practical reasons that I’m missing.

]]> By: Alejandro M. http://blog.reverberate.org/2009/11/28/porting-upb-to-c/comment-page-1/#comment-1481 Alejandro M. Tue, 01 Dec 2009 14:49:08 +0000 http://blog.reverberate.org/?p=287#comment-1481 please don't :'( please don’t :’(

]]>